tidy/
deps.rs

1//! Checks the licenses of third-party dependencies.
2
3use std::collections::{HashMap, HashSet};
4use std::fs::{File, read_dir};
5use std::io::Write;
6use std::path::Path;
7
8use build_helper::ci::CiEnv;
9use cargo_metadata::semver::Version;
10use cargo_metadata::{Metadata, Package, PackageId};
11
12#[path = "../../../bootstrap/src/utils/proc_macro_deps.rs"]
13mod proc_macro_deps;
14
15/// These are licenses that are allowed for all crates, including the runtime,
16/// rustc, tools, etc.
17#[rustfmt::skip]
18const LICENSES: &[&str] = &[
19    // tidy-alphabetical-start
20    "(MIT OR Apache-2.0) AND Unicode-3.0",                 // unicode_ident (1.0.14)
21    "(MIT OR Apache-2.0) AND Unicode-DFS-2016",            // unicode_ident (1.0.12)
22    "0BSD OR MIT OR Apache-2.0",                           // adler2 license
23    "0BSD",
24    "Apache-2.0 / MIT",
25    "Apache-2.0 OR ISC OR MIT",
26    "Apache-2.0 OR MIT",
27    "Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT", // wasi license
28    "Apache-2.0",
29    "Apache-2.0/MIT",
30    "BSD-2-Clause OR Apache-2.0 OR MIT",                   // zerocopy
31    "ISC",
32    "MIT / Apache-2.0",
33    "MIT AND (MIT OR Apache-2.0)",
34    "MIT AND Apache-2.0 WITH LLVM-exception AND (MIT OR Apache-2.0)", // compiler-builtins
35    "MIT OR Apache-2.0 OR LGPL-2.1-or-later",              // r-efi, r-efi-alloc
36    "MIT OR Apache-2.0 OR Zlib",                           // tinyvec_macros
37    "MIT OR Apache-2.0",
38    "MIT OR Zlib OR Apache-2.0",                           // miniz_oxide
39    "MIT",
40    "MIT/Apache-2.0",
41    "Unicode-3.0",                                         // icu4x
42    "Unicode-DFS-2016",                                    // tinystr
43    "Unlicense OR MIT",
44    "Unlicense/MIT",
45    "Zlib OR Apache-2.0 OR MIT",                           // tinyvec
46    // tidy-alphabetical-end
47];
48
49type ExceptionList = &'static [(&'static str, &'static str)];
50
51/// The workspaces to check for licensing and optionally permitted dependencies.
52///
53/// Each entry consists of a tuple with the following elements:
54///
55/// * The path to the workspace root Cargo.toml file.
56/// * The list of license exceptions.
57/// * Optionally a tuple of:
58///     * A list of crates for which dependencies need to be explicitly allowed.
59///     * The list of allowed dependencies.
60/// * Submodules required for the workspace.
61// FIXME auto detect all cargo workspaces
62pub(crate) const WORKSPACES: &[(&str, ExceptionList, Option<(&[&str], &[&str])>, &[&str])] = &[
63    // The root workspace has to be first for check_rustfix to work.
64    (".", EXCEPTIONS, Some((&["rustc-main"], PERMITTED_RUSTC_DEPENDENCIES)), &[]),
65    ("library", EXCEPTIONS_STDLIB, Some((&["sysroot"], PERMITTED_STDLIB_DEPENDENCIES)), &[]),
66    // Outside of the alphabetical section because rustfmt formats it using multiple lines.
67    (
68        "compiler/rustc_codegen_cranelift",
69        EXCEPTIONS_CRANELIFT,
70        Some((&["rustc_codegen_cranelift"], PERMITTED_CRANELIFT_DEPENDENCIES)),
71        &[],
72    ),
73    // tidy-alphabetical-start
74    ("compiler/rustc_codegen_gcc", EXCEPTIONS_GCC, None, &[]),
75    ("src/bootstrap", EXCEPTIONS_BOOTSTRAP, None, &[]),
76    ("src/tools/cargo", EXCEPTIONS_CARGO, None, &["src/tools/cargo"]),
77    //("src/tools/miri/test-cargo-miri", &[], None), // FIXME uncomment once all deps are vendored
78    //("src/tools/miri/test_dependencies", &[], None), // FIXME uncomment once all deps are vendored
79    ("src/tools/rust-analyzer", EXCEPTIONS_RUST_ANALYZER, None, &[]),
80    ("src/tools/rustbook", EXCEPTIONS_RUSTBOOK, None, &["src/doc/book", "src/doc/reference"]),
81    ("src/tools/rustc-perf", EXCEPTIONS_RUSTC_PERF, None, &["src/tools/rustc-perf"]),
82    ("src/tools/test-float-parse", EXCEPTIONS, None, &[]),
83    ("tests/run-make/uefi-qemu/uefi_qemu_test", EXCEPTIONS_UEFI_QEMU_TEST, None, &[]),
84    // tidy-alphabetical-end
85];
86
87/// These are exceptions to Rust's permissive licensing policy, and
88/// should be considered bugs. Exceptions are only allowed in Rust
89/// tooling. It is _crucial_ that no exception crates be dependencies
90/// of the Rust runtime (std/test).
91#[rustfmt::skip]
92const EXCEPTIONS: ExceptionList = &[
93    // tidy-alphabetical-start
94    ("ar_archive_writer", "Apache-2.0 WITH LLVM-exception"), // rustc
95    ("arrayref", "BSD-2-Clause"),                            // rustc
96    ("blake3", "CC0-1.0 OR Apache-2.0 OR Apache-2.0 WITH LLVM-exception"),  // rustc
97    ("colored", "MPL-2.0"),                                  // rustfmt
98    ("constant_time_eq", "CC0-1.0 OR MIT-0 OR Apache-2.0"),  // rustc
99    ("dissimilar", "Apache-2.0"),                            // rustdoc, rustc_lexer (few tests) via expect-test, (dev deps)
100    ("fluent-langneg", "Apache-2.0"),                        // rustc (fluent translations)
101    ("foldhash", "Zlib"),                                    // rustc
102    ("option-ext", "MPL-2.0"),                               // cargo-miri (via `directories`)
103    ("rustc_apfloat", "Apache-2.0 WITH LLVM-exception"),     // rustc (license is the same as LLVM uses)
104    ("ryu", "Apache-2.0 OR BSL-1.0"), // BSL is not acceptble, but we use it under Apache-2.0                       // cargo/... (because of serde)
105    ("self_cell", "Apache-2.0"),                             // rustc (fluent translations)
106    ("wasi-preview1-component-adapter-provider", "Apache-2.0 WITH LLVM-exception"), // rustc
107    // tidy-alphabetical-end
108];
109
110/// These are exceptions to Rust's permissive licensing policy, and
111/// should be considered bugs. Exceptions are only allowed in Rust
112/// tooling. It is _crucial_ that no exception crates be dependencies
113/// of the Rust runtime (std/test).
114#[rustfmt::skip]
115const EXCEPTIONS_STDLIB: ExceptionList = &[
116    // tidy-alphabetical-start
117    ("fortanix-sgx-abi", "MPL-2.0"), // libstd but only for `sgx` target. FIXME: this dependency violates the documentation comment above.
118    // tidy-alphabetical-end
119];
120
121const EXCEPTIONS_CARGO: ExceptionList = &[
122    // tidy-alphabetical-start
123    ("arrayref", "BSD-2-Clause"),
124    ("bitmaps", "MPL-2.0+"),
125    ("blake3", "CC0-1.0 OR Apache-2.0 OR Apache-2.0 WITH LLVM-exception"),
126    ("ciborium", "Apache-2.0"),
127    ("ciborium-io", "Apache-2.0"),
128    ("ciborium-ll", "Apache-2.0"),
129    ("constant_time_eq", "CC0-1.0 OR MIT-0 OR Apache-2.0"),
130    ("dunce", "CC0-1.0 OR MIT-0 OR Apache-2.0"),
131    ("encoding_rs", "(Apache-2.0 OR MIT) AND BSD-3-Clause"),
132    ("fiat-crypto", "MIT OR Apache-2.0 OR BSD-1-Clause"),
133    ("foldhash", "Zlib"),
134    ("im-rc", "MPL-2.0+"),
135    ("libz-rs-sys", "Zlib"),
136    ("normalize-line-endings", "Apache-2.0"),
137    ("openssl", "Apache-2.0"),
138    ("ring", "Apache-2.0 AND ISC"),
139    ("ryu", "Apache-2.0 OR BSL-1.0"), // BSL is not acceptble, but we use it under Apache-2.0
140    ("similar", "Apache-2.0"),
141    ("sized-chunks", "MPL-2.0+"),
142    ("subtle", "BSD-3-Clause"),
143    ("supports-hyperlinks", "Apache-2.0"),
144    ("unicode-bom", "Apache-2.0"),
145    ("zlib-rs", "Zlib"),
146    // tidy-alphabetical-end
147];
148
149const EXCEPTIONS_RUST_ANALYZER: ExceptionList = &[
150    // tidy-alphabetical-start
151    ("dissimilar", "Apache-2.0"),
152    ("foldhash", "Zlib"),
153    ("notify", "CC0-1.0"),
154    ("option-ext", "MPL-2.0"),
155    ("pulldown-cmark-to-cmark", "Apache-2.0"),
156    ("rustc_apfloat", "Apache-2.0 WITH LLVM-exception"),
157    ("ryu", "Apache-2.0 OR BSL-1.0"), // BSL is not acceptble, but we use it under Apache-2.0
158    ("scip", "Apache-2.0"),
159    // tidy-alphabetical-end
160];
161
162const EXCEPTIONS_RUSTC_PERF: ExceptionList = &[
163    // tidy-alphabetical-start
164    ("alloc-no-stdlib", "BSD-3-Clause"),
165    ("alloc-stdlib", "BSD-3-Clause"),
166    ("brotli", "BSD-3-Clause/MIT"),
167    ("brotli-decompressor", "BSD-3-Clause/MIT"),
168    ("encoding_rs", "(Apache-2.0 OR MIT) AND BSD-3-Clause"),
169    ("inferno", "CDDL-1.0"),
170    ("option-ext", "MPL-2.0"),
171    ("ryu", "Apache-2.0 OR BSL-1.0"),
172    ("snap", "BSD-3-Clause"),
173    ("subtle", "BSD-3-Clause"),
174    // tidy-alphabetical-end
175];
176
177const EXCEPTIONS_RUSTBOOK: ExceptionList = &[
178    // tidy-alphabetical-start
179    ("cssparser", "MPL-2.0"),
180    ("cssparser-macros", "MPL-2.0"),
181    ("dtoa-short", "MPL-2.0"),
182    ("mdbook", "MPL-2.0"),
183    ("ryu", "Apache-2.0 OR BSL-1.0"),
184    // tidy-alphabetical-end
185];
186
187const EXCEPTIONS_CRANELIFT: ExceptionList = &[
188    // tidy-alphabetical-start
189    ("cranelift-assembler-x64", "Apache-2.0 WITH LLVM-exception"),
190    ("cranelift-assembler-x64-meta", "Apache-2.0 WITH LLVM-exception"),
191    ("cranelift-bforest", "Apache-2.0 WITH LLVM-exception"),
192    ("cranelift-bitset", "Apache-2.0 WITH LLVM-exception"),
193    ("cranelift-codegen", "Apache-2.0 WITH LLVM-exception"),
194    ("cranelift-codegen-meta", "Apache-2.0 WITH LLVM-exception"),
195    ("cranelift-codegen-shared", "Apache-2.0 WITH LLVM-exception"),
196    ("cranelift-control", "Apache-2.0 WITH LLVM-exception"),
197    ("cranelift-entity", "Apache-2.0 WITH LLVM-exception"),
198    ("cranelift-frontend", "Apache-2.0 WITH LLVM-exception"),
199    ("cranelift-isle", "Apache-2.0 WITH LLVM-exception"),
200    ("cranelift-jit", "Apache-2.0 WITH LLVM-exception"),
201    ("cranelift-module", "Apache-2.0 WITH LLVM-exception"),
202    ("cranelift-native", "Apache-2.0 WITH LLVM-exception"),
203    ("cranelift-object", "Apache-2.0 WITH LLVM-exception"),
204    ("cranelift-srcgen", "Apache-2.0 WITH LLVM-exception"),
205    ("foldhash", "Zlib"),
206    ("mach2", "BSD-2-Clause OR MIT OR Apache-2.0"),
207    ("regalloc2", "Apache-2.0 WITH LLVM-exception"),
208    ("target-lexicon", "Apache-2.0 WITH LLVM-exception"),
209    ("wasmtime-jit-icache-coherence", "Apache-2.0 WITH LLVM-exception"),
210    ("wasmtime-math", "Apache-2.0 WITH LLVM-exception"),
211    // tidy-alphabetical-end
212];
213
214const EXCEPTIONS_GCC: ExceptionList = &[
215    // tidy-alphabetical-start
216    ("gccjit", "GPL-3.0"),
217    ("gccjit_sys", "GPL-3.0"),
218    // tidy-alphabetical-end
219];
220
221const EXCEPTIONS_BOOTSTRAP: ExceptionList = &[
222    ("ryu", "Apache-2.0 OR BSL-1.0"), // through serde. BSL is not acceptble, but we use it under Apache-2.0
223];
224
225const EXCEPTIONS_UEFI_QEMU_TEST: ExceptionList = &[
226    ("r-efi", "MIT OR Apache-2.0 OR LGPL-2.1-or-later"), // LGPL is not acceptable, but we use it under MIT OR Apache-2.0
227];
228
229const PERMITTED_DEPS_LOCATION: &str = concat!(file!(), ":", line!());
230
231/// Crates rustc is allowed to depend on. Avoid adding to the list if possible.
232///
233/// This list is here to provide a speed-bump to adding a new dependency to
234/// rustc. Please check with the compiler team before adding an entry.
235const PERMITTED_RUSTC_DEPENDENCIES: &[&str] = &[
236    // tidy-alphabetical-start
237    "adler2",
238    "aho-corasick",
239    "allocator-api2", // FIXME: only appears in Cargo.lock due to https://github.com/rust-lang/cargo/issues/10801
240    "annotate-snippets",
241    "anstyle",
242    "ar_archive_writer",
243    "arrayref",
244    "arrayvec",
245    "autocfg",
246    "bitflags",
247    "blake3",
248    "block-buffer",
249    "bstr",
250    "cc",
251    "cfg-if",
252    "cfg_aliases",
253    "constant_time_eq",
254    "cpufeatures",
255    "crc32fast",
256    "crossbeam-deque",
257    "crossbeam-epoch",
258    "crossbeam-utils",
259    "crypto-common",
260    "ctrlc",
261    "darling",
262    "darling_core",
263    "darling_macro",
264    "datafrog",
265    "derive-where",
266    "derive_setters",
267    "digest",
268    "displaydoc",
269    "dissimilar",
270    "either",
271    "elsa",
272    "ena",
273    "equivalent",
274    "errno",
275    "expect-test",
276    "fallible-iterator", // dependency of `thorin`
277    "fastrand",
278    "flate2",
279    "fluent-bundle",
280    "fluent-langneg",
281    "fluent-syntax",
282    "fnv",
283    "foldhash",
284    "generic-array",
285    "getopts",
286    "getrandom",
287    "gimli",
288    "gsgdt",
289    "hashbrown",
290    "icu_list",
291    "icu_list_data",
292    "icu_locid",
293    "icu_locid_transform",
294    "icu_locid_transform_data",
295    "icu_provider",
296    "icu_provider_adapters",
297    "icu_provider_macros",
298    "ident_case",
299    "indexmap",
300    "intl-memoizer",
301    "intl_pluralrules",
302    "itertools",
303    "itoa",
304    "jiff",
305    "jiff-static",
306    "jobserver",
307    "lazy_static",
308    "leb128",
309    "libc",
310    "libloading",
311    "linux-raw-sys",
312    "litemap",
313    "lock_api",
314    "log",
315    "matchers",
316    "md-5",
317    "measureme",
318    "memchr",
319    "memmap2",
320    "miniz_oxide",
321    "nix",
322    "nu-ansi-term",
323    "object",
324    "odht",
325    "once_cell",
326    "overload",
327    "parking_lot",
328    "parking_lot_core",
329    "pathdiff",
330    "perf-event-open-sys",
331    "pin-project-lite",
332    "polonius-engine",
333    "portable-atomic", // dependency for platforms doesn't support `AtomicU64` in std
334    "portable-atomic-util",
335    "ppv-lite86",
336    "proc-macro-hack",
337    "proc-macro2",
338    "psm",
339    "pulldown-cmark",
340    "pulldown-cmark-escape",
341    "punycode",
342    "quote",
343    "r-efi",
344    "rand",
345    "rand_chacha",
346    "rand_core",
347    "rand_xorshift", // dependency for doc-tests in rustc_thread_pool
348    "rand_xoshiro",
349    "redox_syscall",
350    "regex",
351    "regex-automata",
352    "regex-syntax",
353    "rustc-demangle",
354    "rustc-hash",
355    "rustc-literal-escaper",
356    "rustc-stable-hash",
357    "rustc_apfloat",
358    "rustix",
359    "ruzstd", // via object in thorin-dwp
360    "ryu",
361    "scoped-tls",
362    "scopeguard",
363    "self_cell",
364    "semver",
365    "serde",
366    "serde_derive",
367    "serde_json",
368    "serde_path_to_error",
369    "sha1",
370    "sha2",
371    "sharded-slab",
372    "shlex",
373    "smallvec",
374    "stable_deref_trait",
375    "stacker",
376    "static_assertions",
377    "strsim",
378    "syn",
379    "synstructure",
380    "tempfile",
381    "termcolor",
382    "termize",
383    "thin-vec",
384    "thiserror",
385    "thiserror-impl",
386    "thorin-dwp",
387    "thread_local",
388    "tikv-jemalloc-sys",
389    "tinystr",
390    "tinyvec",
391    "tinyvec_macros",
392    "tracing",
393    "tracing-attributes",
394    "tracing-core",
395    "tracing-log",
396    "tracing-subscriber",
397    "tracing-tree",
398    "twox-hash",
399    "type-map",
400    "typenum",
401    "unic-langid",
402    "unic-langid-impl",
403    "unic-langid-macros",
404    "unic-langid-macros-impl",
405    "unicase",
406    "unicode-ident",
407    "unicode-normalization",
408    "unicode-properties",
409    "unicode-script",
410    "unicode-security",
411    "unicode-width",
412    "unicode-xid",
413    "valuable",
414    "version_check",
415    "wasi",
416    "wasm-encoder",
417    "wasmparser",
418    "winapi",
419    "winapi-i686-pc-windows-gnu",
420    "winapi-util",
421    "winapi-x86_64-pc-windows-gnu",
422    "windows",
423    "windows-collections",
424    "windows-core",
425    "windows-future",
426    "windows-implement",
427    "windows-interface",
428    "windows-link",
429    "windows-numerics",
430    "windows-result",
431    "windows-strings",
432    "windows-sys",
433    "windows-targets",
434    "windows-threading",
435    "windows_aarch64_gnullvm",
436    "windows_aarch64_msvc",
437    "windows_i686_gnu",
438    "windows_i686_gnullvm",
439    "windows_i686_msvc",
440    "windows_x86_64_gnu",
441    "windows_x86_64_gnullvm",
442    "windows_x86_64_msvc",
443    "wit-bindgen-rt@0.39.0", // pinned to a specific version due to using a binary blob: <https://github.com/rust-lang/rust/pull/136395#issuecomment-2692769062>
444    "writeable",
445    "yoke",
446    "yoke-derive",
447    "zerocopy",
448    "zerocopy-derive",
449    "zerofrom",
450    "zerofrom-derive",
451    "zerovec",
452    "zerovec-derive",
453    // tidy-alphabetical-end
454];
455
456const PERMITTED_STDLIB_DEPENDENCIES: &[&str] = &[
457    // tidy-alphabetical-start
458    "addr2line",
459    "adler2",
460    "cc",
461    "cfg-if",
462    "compiler_builtins",
463    "dlmalloc",
464    "fortanix-sgx-abi",
465    "getopts",
466    "gimli",
467    "hashbrown",
468    "hermit-abi",
469    "libc",
470    "memchr",
471    "miniz_oxide",
472    "object",
473    "r-efi",
474    "r-efi-alloc",
475    "rand",
476    "rand_core",
477    "rand_xorshift",
478    "rustc-demangle",
479    "rustc-literal-escaper",
480    "shlex",
481    "unicode-width",
482    "unwinding",
483    "wasi",
484    "windows-sys",
485    "windows-targets",
486    "windows_aarch64_gnullvm",
487    "windows_aarch64_msvc",
488    "windows_i686_gnu",
489    "windows_i686_gnullvm",
490    "windows_i686_msvc",
491    "windows_x86_64_gnu",
492    "windows_x86_64_gnullvm",
493    "windows_x86_64_msvc",
494    // tidy-alphabetical-end
495];
496
497const PERMITTED_CRANELIFT_DEPENDENCIES: &[&str] = &[
498    // tidy-alphabetical-start
499    "allocator-api2",
500    "anyhow",
501    "arbitrary",
502    "bitflags",
503    "bumpalo",
504    "cfg-if",
505    "cranelift-assembler-x64",
506    "cranelift-assembler-x64-meta",
507    "cranelift-bforest",
508    "cranelift-bitset",
509    "cranelift-codegen",
510    "cranelift-codegen-meta",
511    "cranelift-codegen-shared",
512    "cranelift-control",
513    "cranelift-entity",
514    "cranelift-frontend",
515    "cranelift-isle",
516    "cranelift-jit",
517    "cranelift-module",
518    "cranelift-native",
519    "cranelift-object",
520    "cranelift-srcgen",
521    "crc32fast",
522    "equivalent",
523    "fallible-iterator",
524    "foldhash",
525    "gimli",
526    "hashbrown",
527    "indexmap",
528    "libc",
529    "libloading",
530    "libm",
531    "log",
532    "mach2",
533    "memchr",
534    "object",
535    "proc-macro2",
536    "quote",
537    "regalloc2",
538    "region",
539    "rustc-hash",
540    "serde",
541    "serde_derive",
542    "smallvec",
543    "stable_deref_trait",
544    "syn",
545    "target-lexicon",
546    "unicode-ident",
547    "wasmtime-jit-icache-coherence",
548    "wasmtime-math",
549    "windows-sys",
550    "windows-targets",
551    "windows_aarch64_gnullvm",
552    "windows_aarch64_msvc",
553    "windows_i686_gnu",
554    "windows_i686_gnullvm",
555    "windows_i686_msvc",
556    "windows_x86_64_gnu",
557    "windows_x86_64_gnullvm",
558    "windows_x86_64_msvc",
559    // tidy-alphabetical-end
560];
561
562/// Dependency checks.
563///
564/// `root` is path to the directory with the root `Cargo.toml` (for the workspace). `cargo` is path
565/// to the cargo executable.
566pub fn check(root: &Path, cargo: &Path, bless: bool, bad: &mut bool) {
567    let mut checked_runtime_licenses = false;
568
569    check_proc_macro_dep_list(root, cargo, bless, bad);
570
571    for &(workspace, exceptions, permitted_deps, submodules) in WORKSPACES {
572        if has_missing_submodule(root, submodules) {
573            continue;
574        }
575
576        if !root.join(workspace).join("Cargo.lock").exists() {
577            tidy_error!(bad, "the `{workspace}` workspace doesn't have a Cargo.lock");
578            continue;
579        }
580
581        let mut cmd = cargo_metadata::MetadataCommand::new();
582        cmd.cargo_path(cargo)
583            .manifest_path(root.join(workspace).join("Cargo.toml"))
584            .features(cargo_metadata::CargoOpt::AllFeatures)
585            .other_options(vec!["--locked".to_owned()]);
586        let metadata = t!(cmd.exec());
587
588        check_license_exceptions(&metadata, workspace, exceptions, bad);
589        if let Some((crates, permitted_deps)) = permitted_deps {
590            check_permitted_dependencies(&metadata, workspace, permitted_deps, crates, bad);
591        }
592
593        if workspace == "library" {
594            check_runtime_license_exceptions(&metadata, bad);
595            check_runtime_no_duplicate_dependencies(&metadata, bad);
596            check_runtime_no_proc_macros(&metadata, bad);
597            checked_runtime_licenses = true;
598        }
599    }
600
601    // Sanity check to ensure we don't accidentally remove the workspace containing the runtime
602    // crates.
603    assert!(checked_runtime_licenses);
604}
605
606/// Ensure the list of proc-macro crate transitive dependencies is up to date
607fn check_proc_macro_dep_list(root: &Path, cargo: &Path, bless: bool, bad: &mut bool) {
608    let mut cmd = cargo_metadata::MetadataCommand::new();
609    cmd.cargo_path(cargo)
610        .manifest_path(root.join("Cargo.toml"))
611        .features(cargo_metadata::CargoOpt::AllFeatures)
612        .other_options(vec!["--locked".to_owned()]);
613    let metadata = t!(cmd.exec());
614    let is_proc_macro_pkg = |pkg: &Package| pkg.targets.iter().any(|target| target.is_proc_macro());
615
616    let mut proc_macro_deps = HashSet::new();
617    for pkg in metadata.packages.iter().filter(|pkg| is_proc_macro_pkg(pkg)) {
618        deps_of(&metadata, &pkg.id, &mut proc_macro_deps);
619    }
620    // Remove the proc-macro crates themselves
621    proc_macro_deps.retain(|pkg| !is_proc_macro_pkg(&metadata[pkg]));
622
623    let proc_macro_deps: HashSet<_> =
624        proc_macro_deps.into_iter().map(|dep| metadata[dep].name.as_ref()).collect();
625    let expected = proc_macro_deps::CRATES.iter().copied().collect::<HashSet<_>>();
626
627    let needs_blessing = proc_macro_deps.difference(&expected).next().is_some()
628        || expected.difference(&proc_macro_deps).next().is_some();
629
630    if needs_blessing && bless {
631        let mut proc_macro_deps: Vec<_> = proc_macro_deps.into_iter().collect();
632        proc_macro_deps.sort();
633        let mut file = File::create(root.join("src/bootstrap/src/utils/proc_macro_deps.rs"))
634            .expect("`proc_macro_deps` should exist");
635        writeln!(
636            &mut file,
637            "/// Do not update manually - use `./x.py test tidy --bless`
638/// Holds all direct and indirect dependencies of proc-macro crates in tree.
639/// See <https://github.com/rust-lang/rust/issues/134863>
640pub static CRATES: &[&str] = &[
641    // tidy-alphabetical-start"
642        )
643        .unwrap();
644        for dep in proc_macro_deps {
645            writeln!(&mut file, "    {dep:?},").unwrap();
646        }
647        writeln!(
648            &mut file,
649            "    // tidy-alphabetical-end
650];"
651        )
652        .unwrap();
653    } else {
654        let old_bad = *bad;
655
656        for missing in proc_macro_deps.difference(&expected) {
657            tidy_error!(
658                bad,
659                "proc-macro crate dependency `{missing}` is not registered in `src/bootstrap/src/utils/proc_macro_deps.rs`",
660            );
661        }
662        for extra in expected.difference(&proc_macro_deps) {
663            tidy_error!(
664                bad,
665                "`{extra}` is registered in `src/bootstrap/src/utils/proc_macro_deps.rs`, but is not a proc-macro crate dependency",
666            );
667        }
668        if *bad != old_bad {
669            eprintln!("Run `./x.py test tidy --bless` to regenerate the list");
670        }
671    }
672}
673
674/// Used to skip a check if a submodule is not checked out, and not in a CI environment.
675///
676/// This helps prevent enforcing developers to fetch submodules for tidy.
677pub fn has_missing_submodule(root: &Path, submodules: &[&str]) -> bool {
678    !CiEnv::is_ci()
679        && submodules.iter().any(|submodule| {
680            let path = root.join(submodule);
681            !path.exists()
682            // If the directory is empty, we can consider it as an uninitialized submodule.
683            || read_dir(path).unwrap().next().is_none()
684        })
685}
686
687/// Check that all licenses of runtime dependencies are in the valid list in `LICENSES`.
688///
689/// Unlike for tools we don't allow exceptions to the `LICENSES` list for the runtime with the sole
690/// exception of `fortanix-sgx-abi` which is only used on x86_64-fortanix-unknown-sgx.
691fn check_runtime_license_exceptions(metadata: &Metadata, bad: &mut bool) {
692    for pkg in &metadata.packages {
693        if pkg.source.is_none() {
694            // No need to check local packages.
695            continue;
696        }
697        let license = match &pkg.license {
698            Some(license) => license,
699            None => {
700                tidy_error!(bad, "dependency `{}` does not define a license expression", pkg.id);
701                continue;
702            }
703        };
704        if !LICENSES.contains(&license.as_str()) {
705            // This is a specific exception because SGX is considered "third party".
706            // See https://github.com/rust-lang/rust/issues/62620 for more.
707            // In general, these should never be added and this exception
708            // should not be taken as precedent for any new target.
709            if *pkg.name == "fortanix-sgx-abi" && pkg.license.as_deref() == Some("MPL-2.0") {
710                continue;
711            }
712
713            tidy_error!(bad, "invalid license `{}` in `{}`", license, pkg.id);
714        }
715    }
716}
717
718/// Check that all licenses of tool dependencies are in the valid list in `LICENSES`.
719///
720/// Packages listed in `exceptions` are allowed for tools.
721fn check_license_exceptions(
722    metadata: &Metadata,
723    workspace: &str,
724    exceptions: &[(&str, &str)],
725    bad: &mut bool,
726) {
727    // Validate the EXCEPTIONS list hasn't changed.
728    for (name, license) in exceptions {
729        // Check that the package actually exists.
730        if !metadata.packages.iter().any(|p| *p.name == *name) {
731            tidy_error!(
732                bad,
733                "could not find exception package `{}` in workspace `{workspace}`\n\
734                Remove from EXCEPTIONS list if it is no longer used.",
735                name
736            );
737        }
738        // Check that the license hasn't changed.
739        for pkg in metadata.packages.iter().filter(|p| *p.name == *name) {
740            match &pkg.license {
741                None => {
742                    tidy_error!(
743                        bad,
744                        "dependency exception `{}` in workspace `{workspace}` does not declare a license expression",
745                        pkg.id
746                    );
747                }
748                Some(pkg_license) => {
749                    if pkg_license.as_str() != *license {
750                        println!(
751                            "dependency exception `{name}` license in workspace `{workspace}` has changed"
752                        );
753                        println!("    previously `{license}` now `{pkg_license}`");
754                        println!("    update EXCEPTIONS for the new license");
755                        *bad = true;
756                    }
757                }
758            }
759        }
760    }
761
762    let exception_names: Vec<_> = exceptions.iter().map(|(name, _license)| *name).collect();
763
764    // Check if any package does not have a valid license.
765    for pkg in &metadata.packages {
766        if pkg.source.is_none() {
767            // No need to check local packages.
768            continue;
769        }
770        if exception_names.contains(&pkg.name.as_str()) {
771            continue;
772        }
773        let license = match &pkg.license {
774            Some(license) => license,
775            None => {
776                tidy_error!(
777                    bad,
778                    "dependency `{}` in workspace `{workspace}` does not define a license expression",
779                    pkg.id
780                );
781                continue;
782            }
783        };
784        if !LICENSES.contains(&license.as_str()) {
785            tidy_error!(
786                bad,
787                "invalid license `{}` for package `{}` in workspace `{workspace}`",
788                license,
789                pkg.id
790            );
791        }
792    }
793}
794
795fn check_runtime_no_duplicate_dependencies(metadata: &Metadata, bad: &mut bool) {
796    let mut seen_pkgs = HashSet::new();
797    for pkg in &metadata.packages {
798        if pkg.source.is_none() {
799            continue;
800        }
801
802        if !seen_pkgs.insert(&*pkg.name) {
803            tidy_error!(
804                bad,
805                "duplicate package `{}` is not allowed for the standard library",
806                pkg.name
807            );
808        }
809    }
810}
811
812fn check_runtime_no_proc_macros(metadata: &Metadata, bad: &mut bool) {
813    for pkg in &metadata.packages {
814        if pkg.targets.iter().any(|target| target.is_proc_macro()) {
815            tidy_error!(
816                bad,
817                "proc macro `{}` is not allowed as standard library dependency.\n\
818                Using proc macros in the standard library would break cross-compilation \
819                as proc-macros don't get shipped for the host tuple.",
820                pkg.name
821            );
822        }
823    }
824}
825
826/// Checks the dependency of `restricted_dependency_crates` at the given path. Changes `bad` to
827/// `true` if a check failed.
828///
829/// Specifically, this checks that the dependencies are on the `permitted_dependencies`.
830fn check_permitted_dependencies(
831    metadata: &Metadata,
832    descr: &str,
833    permitted_dependencies: &[&'static str],
834    restricted_dependency_crates: &[&'static str],
835    bad: &mut bool,
836) {
837    let mut has_permitted_dep_error = false;
838    let mut deps = HashSet::new();
839    for to_check in restricted_dependency_crates {
840        let to_check = pkg_from_name(metadata, to_check);
841        deps_of(metadata, &to_check.id, &mut deps);
842    }
843
844    // Check that the PERMITTED_DEPENDENCIES does not have unused entries.
845    for permitted in permitted_dependencies {
846        fn compare(pkg: &Package, permitted: &str) -> bool {
847            if let Some((name, version)) = permitted.split_once("@") {
848                let Ok(version) = Version::parse(version) else {
849                    return false;
850                };
851                *pkg.name == name && pkg.version == version
852            } else {
853                *pkg.name == permitted
854            }
855        }
856        if !deps.iter().any(|dep_id| compare(pkg_from_id(metadata, dep_id), permitted)) {
857            tidy_error!(
858                bad,
859                "could not find allowed package `{permitted}`\n\
860                Remove from PERMITTED_DEPENDENCIES list if it is no longer used.",
861            );
862            has_permitted_dep_error = true;
863        }
864    }
865
866    // Get in a convenient form.
867    let permitted_dependencies: HashMap<_, _> = permitted_dependencies
868        .iter()
869        .map(|s| {
870            if let Some((name, version)) = s.split_once('@') {
871                (name, Version::parse(version).ok())
872            } else {
873                (*s, None)
874            }
875        })
876        .collect();
877
878    for dep in deps {
879        let dep = pkg_from_id(metadata, dep);
880        // If this path is in-tree, we don't require it to be explicitly permitted.
881        if dep.source.is_some() {
882            let is_eq = if let Some(version) = permitted_dependencies.get(dep.name.as_str()) {
883                if let Some(version) = version { version == &dep.version } else { true }
884            } else {
885                false
886            };
887            if !is_eq {
888                tidy_error!(bad, "Dependency for {descr} not explicitly permitted: {}", dep.id);
889                has_permitted_dep_error = true;
890            }
891        }
892    }
893
894    if has_permitted_dep_error {
895        eprintln!("Go to `{PERMITTED_DEPS_LOCATION}` for the list.");
896    }
897}
898
899/// Finds a package with the given name.
900fn pkg_from_name<'a>(metadata: &'a Metadata, name: &'static str) -> &'a Package {
901    let mut i = metadata.packages.iter().filter(|p| *p.name == name);
902    let result =
903        i.next().unwrap_or_else(|| panic!("could not find package `{name}` in package list"));
904    assert!(i.next().is_none(), "more than one package found for `{name}`");
905    result
906}
907
908fn pkg_from_id<'a>(metadata: &'a Metadata, id: &PackageId) -> &'a Package {
909    metadata.packages.iter().find(|p| &p.id == id).unwrap()
910}
911
912/// Recursively find all dependencies.
913fn deps_of<'a>(metadata: &'a Metadata, pkg_id: &'a PackageId, result: &mut HashSet<&'a PackageId>) {
914    if !result.insert(pkg_id) {
915        return;
916    }
917    let node = metadata
918        .resolve
919        .as_ref()
920        .unwrap()
921        .nodes
922        .iter()
923        .find(|n| &n.id == pkg_id)
924        .unwrap_or_else(|| panic!("could not find `{pkg_id}` in resolve"));
925    for dep in &node.deps {
926        deps_of(metadata, &dep.pkg, result);
927    }
928}
tidy/deps.rs

tidy/
deps.rs
